Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($controller): describe your change... #14069

Closed
wants to merge 1 commit into from

Conversation

miccarr
Copy link
Contributor

@miccarr miccarr commented Feb 17, 2016

Swipe ) and ] (mistyped)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Feb 17, 2016

Thx for the PR !
You need to sign the CLA before we can merge this, though.

@gkalpak gkalpak added this to the Purgatory milestone Feb 17, 2016
@miccarr
Copy link
Contributor Author

miccarr commented Feb 18, 2016

Just signed it 😄

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak gkalpak closed this in 2d6c218 Feb 18, 2016
gkalpak pushed a commit that referenced this pull request Feb 18, 2016
gkalpak pushed a commit that referenced this pull request Feb 18, 2016
@gkalpak
Copy link
Member

gkalpak commented Feb 18, 2016

Backported to v1.5.x (96ea2fe) and v1.4.x (7e7a069).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants